Skip to content

Fixing the errors coming up in the pydantic branch #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fixing the errors coming up in the pydantic branch #18

wants to merge 1 commit into from

Conversation

@bcdurak
Copy link
Contributor

@bcdurak bcdurak commented Jun 11, 2024

  • There was a mismatch between the output signature of a step and the input signature of the next step.
  • Steps are being imported, even in the local case. I moved the import sky within the step, so it will not fail for people trying the template locally without skypilot.

@bcdurak bcdurak requested review from avishniakov and safoinme June 11, 2024 15:58
@bcdurak bcdurak changed the title fixing the errors coming up in the pydantic branch Fixing the errors coming up in the pydantic branch Jun 11, 2024
@bcdurak bcdurak closed this Jun 12, 2024
@bcdurak bcdurak deleted the fix/pydantic-upgrade branch June 12, 2024 12:42
@avishniakov avishniakov mentioned this pull request Jun 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@safoinme safoinme Awaiting requested review from safoinme

1 more reviewer

@avishniakov avishniakov avishniakov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bcdurak @avishniakov